Skip to content

[C++] BaseListArray::values() should return either const shared_ptr<Array>& or const Array&, not shared_ptr<Array> #36755

Closed as not planned

Description

@lidavidm

Describe the enhancement requested

The current implementation forces a shared_ptr copy on access

Component(s)

C++

Activity

  1. pitrou commented on Jul 19, 2023

    @pitrou
    Member
  2. js8544 commented on Jul 19, 2023

    @js8544
    Contributor

    I believe it was changed to returning a const reference in #36418

  3. pitrou commented on Jul 19, 2023

    @pitrou
    Member

    Well, yes, it was. Thanks a lot @js8544 :-)

  4. lidavidm commented on Jul 19, 2023

    @lidavidm
    MemberAuthor

    Ah, sorry, I should've confirmed on main first...

  5. felipecrv commented on Jul 19, 2023

    @felipecrv
    Contributor

    @lidavidm this bothered me as well. ;-) #36418 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions