You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[C++] BaseListArray::values() should return either const shared_ptr<Array>& or const Array&, not shared_ptr<Array> #36755
Activity
pitrou commentedon Jul 19, 2023
cc @felipecrv
js8544 commentedon Jul 19, 2023
I believe it was changed to returning a const reference in #36418
pitrou commentedon Jul 19, 2023
Well, yes, it was. Thanks a lot @js8544 :-)
lidavidm commentedon Jul 19, 2023
Ah, sorry, I should've confirmed on main first...
felipecrv commentedon Jul 19, 2023
@lidavidm this bothered me as well. ;-) #36418 (comment)