Skip to content

[C++][Parquet] WipeOutDecryptionKeys doesn't securely wipe out keys #31603

Closed

Description

@asfimport

InternalFileDecryptor::WipeOutDecryptionKeys() merely call std::string::clear to dispose of the decryption key contents, but that method is not guaranteed to clear memory (it probably doesn't, actually).

We should probably devise a portable wrapper function for the various OS-specific memory clearing utilities.

Reporter: Antoine Pitrou / @pitrou

Note: This issue was originally created as ARROW-16202. Please see the migration documentation for further details.

Activity

  1. asfimport commented on Apr 14, 2022

    @asfimport
    Author
  2. asfimport commented on Apr 14, 2022

    @asfimport
    Author

    Antoine Pitrou / @pitrou:
    Actually we probably need a SecureString facility so that wiping happens every time a string copy is done.

  3. asfimport commented on Apr 14, 2022

    @asfimport
    Author

    Antoine Pitrou / @pitrou:
    Draft PR for a low-level helper here: #12890

  4. asfimport commented on Apr 21, 2022

    @asfimport
    Author

    Krisztian Szucs / @kszucs:
    @pitrou shall we postpone it to 9.0?

  5. asfimport commented on Apr 21, 2022

    @asfimport
    Author

    Antoine Pitrou / @pitrou:
    Yes, probably.

  6. asfimport commented on Apr 26, 2022

    @asfimport
    Author
  7. added this to the 11.0.0 milestone on Jan 11, 2023
  8. removed this from the 11.0.0 milestone on Jan 11, 2023
  9. pitrou commented on Mar 21, 2024

    @pitrou
    Member

    @adamreeve For the record, you might be interested in this.

  10. added a commit that references this issue on Jun 9, 2025
  11. added a commit that references this issue on Jun 17, 2025
  12. added a commit that references this issue on Jul 15, 2025
  13. added this to the 22.0.0 milestone on Jul 15, 2025
  14. pitrou commented on Jul 15, 2025

    @pitrou
    Member

    Issue resolved by pull request 46017
    #46017

  15. pitrou commented on Jul 15, 2025

    @pitrou
    Member

    @EnricoMi Can you post a comment here so that we can assign this issue to you?

  16. EnricoMi commented on Jul 15, 2025

    @EnricoMi
    Collaborator

    Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions