Repository navigation
refactor(arrow/compute/exprs)!: remove deprecated Substrait anchor APIs - #1627
Draft
benbellick wants to merge 11 commits into
Draft
benbellick wants to merge 11 commits into
benbellick wants to merge 11 commits into
Conversation
benbellick
marked this pull request as ready for review
November 19, 2026 18:14
benbellick
marked this pull request as draft
November 19, 2026 18:14
Remove the deprecated anchor wrappers and ExtensionIDSet interface in the next major release. Keep the concrete extension set private and stop promoting registry methods. GetSubstraitRegistry remains available.
benbellick
force-pushed
the
spike/remove-deprecated-substrait-anchors
branch
from
November 19, 2026 18:15
5534d96 to
8fb4162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the anchor APIs deprecated in #1500 for the next major release. Anchor allocation and lookup become private helpers rather than part of Arrow’s public API.
ExtensionIDSetnow supplies the Arrow and Substrait registries used by those helpers. Callers that use the deprecated methods must migrate to the higher-level conversion and execution APIs.The motivation is substrait-go#161, which proposes removing anchors from
substrait-go's public model. Handling Arrow's API change now avoids having to introduce that breaking change as part of a futuresubstrait-goupgrade.Part of #1623.
Stack
Note: This PR was developed with AI assistance. All changes have been reviewed, and I take full responsibility for this contribution.