Repository navigation
Add pointer scrubbing for NumberInput and VectorInput - #196
Merged
Merged
Conversation
NumberDragDispatcher captures a primary press on a number input's label, field or padding, focuses it, and after a horizontal threshold requests whole steps from the press through the input's own command. Escape while scrubbing restores the origin; PointerCancel keeps the last value. The Inspector scrubs Scale and Position X/Y/Z from their parsed drafts, with active feedback and a Windows horizontal resize cursor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NumberDragDispatcherandnumber_drag_target(number_drag.hpp) for horizontal pointer scrubbing over everyNumberInputandVectorInputcomponent. No new parts, roles or document vocabulary.startedtells the host to record the origin value. Escape/Cancel while scrubbing requests 0 steps (canceled).PointerCancelkeeps the last value. Other key, text and logical input ends capture unconsumed. Replacement keeps a compatible capture by author ID. Step parts are not targets.Verification
number_drag: targets, click vs. threshold, truncated steps, cancellation, replacement, rejection.inspector_hierarchywindow-free smoke: newscrub_smoke. The injected native smoke drags the X label under OS capture.number_drag,inspector_hierarchyandinspector_hierarchy_nativepass (native 13 s).scripts/check-docs.ps1passes. Formatted with clang-format 23.1.1.Note: in Debug,
inspector_hierarchy_nativeexceeds its 60 s CTest timeout (it passes standalone in 155 s). This change adds only three injected messages, so the slow Debug run is very likely pre-existing. I did not re-measure it onmain.Not included
Modifier-scaled or vertical scrubbing, scrub history transactions in the Inspector (each change is a separate command, like the Display color drag), pointer caret placement, native accessibility.
🤖 Generated with Claude Code