Skip to content

Group Replay step rollback state - #190

Merged
snkmcb merged 1 commit into
mainfrom
codex/replay-step-rollback
Nov 9, 2026
Merged

snkmcb merged 1 commit into
mainfrom
codex/replay-step-rollback

Conversation

@snkmcb

@snkmcb snkmcb commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Summary

ReplayPlayer::apply backed up and restored the viewport, scale, animation clock, host slots, requested scroll offsets and input clock one field at a time. Adding a step input required editing both lists.

Group those inputs in a private StepState and restore it in one assignment on rejection before commit. Tree replacement still restores its own snapshot. This preserves the public API, recording formats, and the existing commit and close behavior.

Add a regression test that rejects a reload after scrolling, then settles another generation to verify that layout still uses the previous requested offset and that accepted steps reproduce the session.

Verification

  • Windows x64 Debug build of Replay, Replay host, Replay serialization, offscreen runner and the Hierarchy / Inspector example.
  • CTest replay, replay_host, replay_serialization, offscreen_runner and inspector_hierarchy passed.
  • Changed-file C++ format, documentation, release metadata, and CI selection checks passed.

@snkmcb
snkmcb merged commit ff3d3e9 into main Nov 9, 2026
3 checks passed
@snkmcb
snkmcb deleted the codex/replay-step-rollback branch November 9, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant