Repository navigation
Group Replay step rollback state - #190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReplayPlayer::applybacked up and restored the viewport, scale, animation clock, host slots, requested scroll offsets and input clock one field at a time. Adding a step input required editing both lists.Group those inputs in a private
StepStateand restore it in one assignment on rejection before commit. Tree replacement still restores its own snapshot. This preserves the public API, recording formats, and the existing commit and close behavior.Add a regression test that rejects a reload after scrolling, then settles another generation to verify that layout still uses the previous requested offset and that accepted steps reproduce the session.
Verification
replay,replay_host,replay_serialization,offscreen_runnerandinspector_hierarchypassed.