Repository navigation
Conversation
mqpcheckv's negative (error) return was assigned to the unsigned maximum of quadratic-constraint sizes, which wrapped and shrank the allocation; the driver then wrote past the buffer before rejecting the model. Found by an AddressSanitizer end2end run. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
fdabrandao
approved these changes
Nov 13, 2026
fdabrandao
left a comment
Member
There was a problem hiding this comment.
Reviewed: the nelqc > 0 guard fixes the signed/unsigned comparison. A negative mqpcheckv return was converted to a huge unsigned value, so k became about SIZE_MAX and the Malloc size overflowed. Errors are still reported by the later loop (solve_result_num 522/525).
Minor, non-blocking: the changelog entry sits under an 'unreleased' heading, while earlier entries use dated headings, so it needs updating at release time.
I read the diff and the surrounding code but did not build or run it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mqpcheckv's negative (error) return was assigned to the unsigned maximum of quadratic-constraint sizes, which wrapped and shrank the allocation; the driver then wrote past the buffer before rejecting the model. Found by an AddressSanitizer end2end run.