Repository navigation
Conversation
hvseq reads each fixture with pfgh_read, calls hvcomp once at each of 12 points and compares the products with central differences of the Lagrangian gradient. This covers the stale products that solvers2 returned after x changed (fixed in 5b49061), which derivcheck does not reach: it calls hvcomp once per variable at each of its two points. Without that fix 13 of the new tests fail with solvers2. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Review of
|
|
I found two issues in this change:
Validation: all 882 registered tests passed locally on macOS with Co-Authored-By: GPT-6 noreply@openai.com |
|
Follow-up after reading the Codex review:
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com |
|
Follow-up on Claude's review, with additional validation:
The buffer overflow and non-finite-result acceptance remain the two independently reproduced issues in my preceding comment. I would treat the proposed helper consolidation as optional cleanup. Co-Authored-By: GPT-6 noreply@openai.com |
…and non-finite checks Review findings on the sequence checker: - constraint values overflowed the workspace when m > 3n: separate buffer; - a run that skipped every point passed: exit 4 when fewer than two points are compared; - an infinite product or difference passed the tolerance test: non-finite values are mismatches; - the absolute step 1e-6 gave false mismatches at large |x|: the direction is scaled with the point and the step reduced near bounds; - points are moved strictly inside the variable bounds, as in derivcheck; - hvcomp got a one-element weight vector on models with several objectives and read past it: no weight vector is passed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Comments addressed (fixing 1 more issue) |
| } | ||
|
|
||
| int main(int argc, char **argv) { | ||
| FILE *nl; int K = argc > 2 ? atoi(argv[2]) : 12, n, m, i, k, r; |
There was a problem hiding this comment.
npoints is not validated. hvseq stub -1 aborts in Malloc (malloc(18446744073709551600) failure), and hvseq stub 0 or hvseq stub abc (atoi gives 0) runs on zero points and exits 0, because checked < (K<2?K:2) is 0 < 0. CMake always uses the default of 12, so this only affects manual runs. Suggest rejecting K < 1 with the usage message and exit status 2.
| for (i = 0; i < n_con && !ne; i++) congrd(i, x, w, &ne); | ||
| if (ne) return 1; | ||
| /* no weight vector: it would need one weight per objective */ | ||
| hvcomp(hv, p, n_obj ? 0 : -1, 0, n_con ? Y : 0); |
There was a problem hiding this comment.
Only objective 0 is exercised: hvcomp is called with objective index 0 here, and lagrgrad uses objgrd(0, ...), so objectives 1 and later are never covered. The README documents that sequences are covered for hvcomp only, but not this limit. Suggest adding a line to the README's limitations list.
hvseq reads each fixture with pfgh_read, calls hvcomp once at each of 12 points and compares the products with central differences of the Lagrangian gradient. This covers the stale products that solvers2 returned after x changed (fixed in 5b49061), which derivcheck does not reach: it calls hvcomp once per variable at each of its two points. Without that fix 13 of the new tests fail with solvers2.