Repository navigation
Conversation
A static final BouncyCastleProvider is reused across hash calls and signer instances. Each call still creates its own MessageDigest, and null inputs still return null. Tests now cover known digests, empty input, repeated calls across signer instances, and concurrent calls. Fixes aliyun#965
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Repeated SM3 hash calls incur unnecessary overhead, slowing callers that hash many inputs.
HmacSM3Signer.hash constructs a new BouncyCastleProvider for every non-null input. This repeats expensive provider initialization on every call.
What changed
A static final BouncyCastleProvider is reused across hash calls and signer instances. Each call still creates its own MessageDigest, and null inputs still return null. Tests now cover known digests, empty input, repeated calls across signer instances, and concurrent calls.
Testing
Mvn -B -ntp test -Dtest=HmacSM3SignerTest -Dsurefire.failIfNoSpecifiedTests=false failed during test compilation because the JDK does not support source and target level 6; no tests ran.
Fixes #965