Repository navigation
Conversation
Max Smythe (maxsmythe)
enabled auto-merge
October 8, 2026 08:16
auto-merge was automatically disabled
October 25, 2026 10:45
Head branch was pushed to by a user without write access
aiqubits
force-pushed
the
fix/ateapi-internal-error-disclosure
branch
from
October 25, 2026 10:45
b99b339 to
0cd7d28
Compare
Contributor
Author
|
Max Smythe (@maxsmythe) I only updated the branches and tests to ensure that CI passed, and there were no changes to other fixes. Please review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: fix(ateapi): hide unexpected backend errors from RPC clients
Fixes #2277.
Unexpected ateapi handler errors currently expose backend diagnostics to external RPC callers. Return an opaque
Internalmessage with the active trace ID when available, while retaining the original error in the existing server log for diagnosis.Explicit
apierrorand context error mappings retain their existing codes and messages. The change is limited to the public unary interceptor and its regression tests.Validation:
Regression tests fail before the fix and pass afterward. Race tests pass across seven related packages, including the ateapi services and CLI.
Additional review-only gRPC transport checks pass for status details, sampled and unsampled tracing, invalid span contexts, cancellation, deadlines, and response trailers.
Code generation, module, formatting, repository-wide lint, Kubernetes API, boilerplate, and license checks pass.
Tests pass (targeted tests pass; full-suite baseline failures are listed above)
Appropriate changes to documentation are included in the PR (interceptor contract comment updated)