Repository navigation
Fix for wrong mime type mismatch detection - #96
Merged
lisaSW merged 4 commits intoSep 25, 2026
Merged
Conversation
lisaSW
changed the base branch from
develop
to
mime-type-mismatch-false-positives
September 25, 2026 20:18
lisaSW
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since when dealing with multiple extensions related to a single mime type there are multiple rows for each extension, the query will flag a mismatch if the extension was different from the first extension found for the mime type in the
valid_mime_typestable, even though the same extension for that mime type could be in some other row.This approach doesn't change the db schema and instead works on a query which separates aggregated extensions between the mime types.