Repository navigation
Keep button_to action items on the title bar's row - #73
Merged
Merged
Conversation
A button_to renders as a block-level <form>, which drops to its own line once consumers delete their old float workaround (the float itself collapsed the flex bar's height — the button hung below the bar). inline-block keeps the form in the row like its anchor siblings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-liner follow-up to #72, caught by the live regression pass on the console: a
button_toaction item renders as a block<form>, so once a consumer deletes its oldfloat: leftworkaround the button drops onto its own line and the title bar stacks (screenshot-verified on a customer show page with three button_to items).display: inline-blockon.action_item > formkeeps it in the row like its anchor siblings.rake csspasses.