licensedcode: point at licensedcode-data when no builtin licenses load - #5341
Open
kumarasantosh wants to merge 1 commit into
Open
kumarasantosh wants to merge 1 commit into
kumarasantosh wants to merge 1 commit into
Conversation
When the builtin license data directory is empty, which happens when scancode-toolkit is installed without the optional licensedcode-data package, the InvalidLicense error now says that licensedcode-data may be missing and how to install it. Fixes aboutcode-org#5053 Signed-off-by: Santosh Pulikonda <santosh.pulikond02@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5053
Problem
licensedcode-datais an optional extra (scancode-toolkit[licenses]). When it isnot installed,
load_licenses()raises a generic "No licenses were loaded" errorthat doesn't say what is missing.
Change
InvalidLicensemessagenow says the
licensedcode-datapackage may be missing and how to install it(
pip install licensedcode-dataorpip install scancode-toolkit[licenses]).tests/licensedcode/test_license_models.py.