Repository navigation
CABI: don't trap if the last thread of a task exits before the task is resolved - #767
Merged
Merged
Conversation
…s resolved Resolves #763
alexcrichton
approved these changes
Nov 16, 2026
alexcrichton
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, but @dicej should be sure to take a look too
dicej
approved these changes
Nov 16, 2026
dicej
left a comment
Collaborator
There was a problem hiding this comment.
I'm kind of ambivalent about this. I do agree that there are other ways to end up with a never-resolved task, but I also feel like this is akin to runtime deadlock detection; just because you can't catch all of them doesn't mean you shouldn't try to catch the obvious ones. Perhaps "catching" in this case just means "provide a runtime option to print a warning or trap to a debugger when a guest does this", though.
Anyway, no real objections.
Member
Author
|
@dicej Agreed: I think debugger options are the best route here for detecting deadlocks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #763, this PR removes a trap that used to be more load-bearing, but now seems superfluous since there are plenty of other ways to end up with a never-resolved task. The PR also adds some new tests for the new allowed behavior.