Repository navigation
Conversation
Needs to handle methods, probably constructors, missing args (?), correct number of instanceofs, probably a bunch of other nonsense
Still need to stomp some duplicate instanceof cases (the goal is one per argument per resource type in the entire overload set), undefined/null, lockdown mode?, self param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
union(a variant ofvariant) and function overloading. The design of unions is mostly unchanged from what @eqrion originally proposed (maybe modulo some of the mapping from types to distinguishable kinds). The design of overloads changed a bit to have optional suffixes of the form#foo, which can be applied to any function (except getters and setters).A couple TODOs still:
foo#barto an interface that already has a funcfoo)Resolves #724, resolves #742.