Repository navigation
ci: fix stale benchmark cache by using unique keys - #161
Open
sailingKieler wants to merge 1 commit into
Open
sailingKieler wants to merge 1 commit into
sailingKieler wants to merge 1 commit into
Conversation
actions/cache never overwrites an existing key, so the fixed '<os>-benchmark' key froze the benchmark baseline after the first save. Split into cache/restore (newest entry via restore-keys) and cache/save (unique run_id key, main branch only). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark action setup example of https://github.com/benchmark-action/github-action-benchmark/#minimal-setup has a flaw in updating the cached benchmark results with
actions/cache, because of:(see https://github.com/actions/cache#using-a-combination-of-restore-and-save-actions)
See also the recent runs of Benchmark/main, e.g. https://github.com/TypeFox/fastbelt/actions/runs/39764627738/job/119776904591:
This PR refines the benchmark workflow to persist a new benchmark snapshot on each run on branch
main.