Skip to content

fix: instagram_crawler.py declares 3.13 but uses 3.14 except syntax - #15551

Open
peda-cos wants to merge 2 commits into
TheAlgorithms:masterfrom
peda-cos:fix/instagram-crawler-except-syntax
Open

peda-cos wants to merge 2 commits into
TheAlgorithms:masterfrom
peda-cos:fix/instagram-crawler-except-syntax

Conversation

@peda-cos

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Description

Same root cause as the PEP 758 fix in web_programming/crypto_price_tracker.py (#15550): the script declares requires-python = ">=3.13" in inline metadata but catches exceptions unparenthesized, which only parses on 3.14. On Python 3.13 exactly, loading the script raises SyntaxError before any request runs.

One-line fix, no behavior change on 3.14+.

How I tested

  • ty check resolves the preamble version and reports error[invalid-syntax]: Multiple exception types must be parenthesized on Python 3.13 before the change and nothing after.
  • ruff check web_programming/instagram_crawler.py passes.

@peda-cos
peda-cos requested a review from cclauss as a code owner October 11, 2026 04:58
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 11, 2026
PEP 758 syntax requires Python 3.14, but the script metadata declares
requires-python >= 3.13. Reported by ty check run per TheAlgorithms#15187.
@peda-cos
peda-cos force-pushed the fix/instagram-crawler-except-syntax branch from 026742f to c780001 Compare October 11, 2026 04:59
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 11, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant