Repository navigation
Conversation
Signed-off-by: Naveen Venkat <81929600+naveenvenk17@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that the tiles_ vector is cleared and reserved during TileGrid::initTiles initialization to prevent stale pointers. It also introduces a comprehensive set of unit tests in route_base_test.cpp to verify grid reinitialization, resizing, and weighted congestion calculations. I have no feedback to provide.
Contributor
Author
|
I also ran all three new cases under ASan on the VM at |
LucasYuki
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this while checking the default-off results for #11899.
TileGrid::initTiles()resizes the tile storage but keeps appending to its pointer list. Repeating initialization leaves duplicate pointers; changing the grid size can also leave references to old storage. The duplicates distort RUDY's weighted congestion metric because its percentile sample sizes are rounded up.Clear the list and reserve space before rebuilding it.
Tested on the GCP Linux VM, with test-result caching disabled:
mt_invariance01failure is an existing hardware INFO-line/golden-log mismatch. Its raw log, diff and DEF are byte-identical to the pure-upstream control, and the DEF matches the unchanged golden. Four GPU targets were skipped.No golden files or metric limits were changed. This separates the grid bug from the opt-in inflation work in #11899.