Repository navigation
Conversation
Signed-off-by: Naveen Venkat <81929600+naveenvenk17@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates SimulatedAnnealingCore::reportLocations to convert database units (DBU) to microns when reporting macro coordinates and dimensions. It also simplifies the loop that iterates over fixed terminals. A review comment suggests casting macros_.size() to int in the loop condition to prevent potential signed/unsigned comparison compiler warnings.
AcKoucher
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #11318 with the same code and a corrected commit sign-off. The source tree is unchanged:
9c158b7720ecc8e236b50c50d9285a83f783ed76.The location report passed integer DBU values to floating-point formatting, which could fail instead of printing the table. Convert coordinates and dimensions to microns for hard and soft macros, matching the outline report.
This also includes the loop change requested in review: fixed-terminal reporting starts at the number of movable macros, so it no longer skips the first fixed terminal.
Validation from this exact source tree on the GCP Linux VM:
The original PR's head and merge CI also passed. This replacement will run its own checks.
Fixes #11241.