Skip to content

mpl: print macro locations in microns - #11910

Merged
AcKoucher merged 1 commit into
The-OpenROAD-Project:masterfrom
naveenvenk17:nv-mpl-report-locations-signed
Oct 21, 2026
Merged

AcKoucher merged 1 commit into
The-OpenROAD-Project:masterfrom
naveenvenk17:nv-mpl-report-locations-signed

Conversation

@naveenvenk17

Copy link
Copy Markdown
Contributor

Replaces #11318 with the same code and a corrected commit sign-off. The source tree is unchanged: 9c158b7720ecc8e236b50c50d9285a83f783ed76.

The location report passed integer DBU values to floating-point formatting, which could fail instead of printing the table. Convert coordinates and dimensions to microns for hard and soft macros, matching the outline report.

This also includes the loop change requested in review: fixed-terminal reporting starts at the number of movable macros, so it no longer skips the first fixed terminal.

Validation from this exact source tree on the GCP Linux VM:

  • All 44 MPL Bazel targets passed with test-result caching disabled.
  • A probe of the actual hard/soft reporter instantiations passed five shuffled runs, covering 140 scenario checks: empty and mixed lists, ordering, the first fixed terminal, negative coordinates, and 1000/2000 DBU-per-micron units.
  • Formatting and whitespace checks passed.

The original PR's head and merge CI also passed. This replacement will run its own checks.

Fixes #11241.

Signed-off-by: Naveen Venkat <81929600+naveenvenk17@users.noreply.github.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates SimulatedAnnealingCore::reportLocations to convert database units (DBU) to microns when reporting macro coordinates and dimensions. It also simplifies the loop that iterates over fixed terminals. A review comment suggests casting macros_.size() to int in the loop condition to prevent potential signed/unsigned comparison compiler warnings.

Comment thread src/mpl/src/SimulatedAnnealingCore.cpp Resolved
@AcKoucher
AcKoucher merged commit 2f6f0a9 into The-OpenROAD-Project:master Oct 21, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mpl: reportLocations prints "invalid format specifier" instead of macro locations

2 participants