Repository navigation
Issue 231: Bring in newer, established, Dockerfile practices. - #232
Merged
Merged
Conversation
Fix the `USER_ID` situation by brining in known working practices. This pulls from the `ibis_service`. The `UPDATE_MAVEN` is usually `false`, but in this case it is set to `true` to preserve existing behavior of previous **Docker** file. The following are new configuration variables: - `DIR_HOME` - `DIR_SERVE` - `DIR_SOURCE` - `BUILD_JAR` - `JAVA_VERSION`: Default set to **Java 11**. - `MAVEN_ARGS` - `PATH_JAR`: Defaults to `service/target/ROOT.jar`. - `UPDATE_MAVEN`: Default set to `true`. - `UPDATE_SERVE`: Default set to `true`. The `USER_ID` is added back. The `USER_NAME` remains. **Alpine** is now used for doing **Maven** building as well. Bring in the documentation changes provided by `ibis_service` as well.
Coverage Report for CI Build 35614912832Coverage remained the same at 63.258%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
rmathew1011
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #231 .
Details
Fix the
USER_IDsituation by brining in known working practices.This pulls from the
ibis_service.The
UPDATE_MAVENis usuallyfalse, but in this case it is set totrueto preserve existing behavior of previous Docker file.The following are new configuration variables:
DIR_HOMEDIR_SERVEDIR_SOURCEBUILD_JARJAVA_VERSION: Default set to Java 11.MAVEN_ARGSPATH_JAR: Defaults toservice/target/ROOT.jar.UPDATE_MAVEN: Default set totrue.UPDATE_SERVE: Default set totrue.The
USER_IDis added back.The
USER_NAMEremains.Alpine is now used for doing Maven building as well.
Bring in the documentation changes provided by
ibis_serviceas well.