Repository navigation
Conversation
librespot-playback backends such as PortAudio query CoreAudio's device list and default output device once when the sink is constructed (Pa_Initialize + get_default_output_index in PortAudioSink::open). On macOS, connecting or disconnecting Bluetooth headphones, plugging into a dock, or switching outputs in Control Center updates CoreAudio's kAudioHardwarePropertyDefaultOutputDevice without notifying PortAudio, leaving a long-running spotifyd writing to the stale output device. When no explicit --device is configured on macOS, wrap the backend in DefaultOutputSink, which queries kAudioHardwarePropertyDefaultOutputDevice via CoreAudio.framework and reopens the underlying sink when the default output AudioDeviceID changes, and closes the inner sink on stop() so no CoreAudio stream is held open while idle.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
librespot-playback backends such as PortAudio query CoreAudio's device list and default output device once when the sink is constructed (Pa_Initialize + get_default_output_index in PortAudioSink::open). On macOS, connecting or disconnecting Bluetooth headphones, plugging into a dock, or switching outputs in Control Center updates CoreAudio's kAudioHardwarePropertyDefaultOutputDevice without notifying PortAudio, leaving a long-running spotifyd writing to the stale output device.
When no explicit --device is configured on macOS, wrap the backend in DefaultOutputSink, which queries kAudioHardwarePropertyDefaultOutputDevice via CoreAudio.framework and reopens the underlying sink when the default output AudioDeviceID changes, and closes the inner sink on stop() so no CoreAudio stream is held open while idle.