Repository navigation
configure toolkit for watch - #9
SharonStrats wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Watch-mode plugin and output filtering mishandle valid Vite configuration shapes.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds watch-mode support while reducing unnecessary watch outputs.
Changes:
- Adds a
watchpackage script. - Disables declaration generation during watch mode.
- Limits watch builds to ES output.
| File | Description |
|---|---|
package.json |
Adds the watch command. |
src/vite/plugins/solid-pane.ts |
Omits DTS generation while watching. |
src/vite/config/build.ts |
Filters watch-mode build outputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
99cf723 to
eff2075
Compare
NoelDeMartin
left a comment
There was a problem hiding this comment.
Changes look good! This adds a bit of a hidden behaviour, which is that during watch ESM are the only emitted files. I don't think that's the expected behaviour, but given that this is something we're using in our own stack it should be fine, just noting that it may cause confusion.
About the rdflib version, it's already declared as ^2.3.6 in the peerDependencies, so it should be ok to leave this as it is. Though if something important has changed in rdflib that would affect this package, then we should update it here as well.

The shared toolkit watch behavior was updated so that watch mode now:
That reduces each rebuild to a single cleaner wave of file writes, which stops the watcher churn.
Note: @NoelDeMartin The rdflib dependency is a much lower version than our current one, not sure if I should change that too?
Also, more testing i ended up having to change mashilb webpack to point to solid-panes esm... i'm going to test some more before merge but would still like to get your feedback.