Repository navigation
Parse negative Unix timestamp strings in the date filter - #2119
Closed
Shubham-Padkonde wants to merge 1 commit into
Closed
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The date filter accepts negative integer Unix timestamps but leaves equivalent strings unchanged. For example, in UTC,
-1formats as12/31/1969while"-1"remains"-1". This affects timestamps for dates before 1970 received as strings.Allow an optional minus sign in the Unix timestamp pattern. Add filter and template rendering regressions, including a timestamp for 1900.
Validation: the new regression fails on the base revision.
bundle exec rakepasses on Ruby 3.3.6: the full 1,041-test suite and 788-test integration suite each pass in lax, strict, and strict2 modes. RuboCop checks 158 files with no offenses.Prepared with Codex assistance.