Skip to content

Fix theme dev failures with large storefront headers - #8746

Closed
efegokdemir wants to merge 2 commits into
Shopify:mainfrom
efegokdemir:codex/theme-dev-large-headers-8717
Closed

efegokdemir wants to merge 2 commits into
Shopify:mainfrom
efegokdemir:codex/theme-dev-large-headers-8717

Conversation

@efegokdemir

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes #8717

The theme dev proxy inherits Node and Undici header-size defaults. Cookie-heavy storefronts can exceed those defaults and return 502s.

WHAT is this pull request doing?

  • Explicitly allow 128 KiB headers for storefront requests and the local theme dev server, including forwarded cookie headers.
  • Preserve Shopify proxy environment settings with an Undici EnvHttpProxyAgent and show network error codes on the storefront error page.
  • Add regression coverage for large upstream response headers, large local request headers, and error-code display, plus a theme patch changeset.

How to manually test your changes?

Run shopify theme dev for a storefront whose browser cookie jar produces more than 40 KiB of headers. Confirm storefront pages continue to render and localhost cookie forwarding does not return 502.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

@github-actions github-actions Bot closed this Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: theme dev proxy 502s on cookie-heavy storefront responses (undici default 16 KiB maxHeaderSize)

1 participant