Fix slash escaping in entity keys and navigation paths - #320
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Fixes SAP#282 while retaining navigation separators and the encoding opt-out.
|
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An entity key such as
/BAZ/FOOcurrently leaves its slashes unescaped, which can make the server interpret part of the key as a path. Encode slashes inside OData quoted literals while retaining separators outside them. This also handles doubled apostrophes and preserves theencode_path=Falseopt-out.Fixes #282. The earlier attempt in #284 identified navigation as a limitation; the literal-aware encoding here covers both collection and single-entity navigation without encoding their separators. Tests also cover changeset/batch serialization and decoding, percent signs, and GET/update/delete paths.
Validation: all 312 tests pass (
pytest --cov-report term --cov=pyodata), Pylint scores 10/10, pinned Flake8 passes, andgit diff --checkpasses. Seven initial regression cases failed before the fix.