Repository navigation
Conversation
…tistics and Information lectures A review of the eighteen lectures in the Statistics and Information part found mathematical, statistical and coding errors, several of which changed published figures. This commit corrects them, harmonizes notation, adds cross-links among the lectures, and adds exercises with solutions, including three each to the seven lectures that had none. Errors that altered results: - navy_captain: a parallel numba reduction zeroed the Bayesian value function, so the fixed-sample versus sequential comparison was 18 vs 0. - merging_of_opinions: the proof of Blackwell-Dubins rested on a false supermartingale claim; replaced by a correct argument. - likelihood_ratio_process_2: mu_1 and mu_2 were swapped in the equilibrium allocation; the Pareto weight is pinned down by budgets. - pricing_information: the regularity condition was reversed and the best single-item revenue mislabelled. - likelihood_var: the observation matrix was off by one period and the steady state was wrong. - wald_friedman: the Jensen-Shannon distance was computed incorrectly. - divergence_measures, likelihood_ratio_process: sign and direction errors, an invalid KL account of maximum likelihood, and truncated integrals. - survival_recursive_preferences, market_diffusion, exchangeable, likelihood_bayes, mix_model, imp_sample, wald_friedman_2, information_market_equilibrium, blackwell_kihlstrom: corrections listed in the review. Adds 15 bibliography entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The change is too large and math- and notebook-heavy, with numerous specific numeric claims that can only be verified through a complete Jupyter Book build beyond this review's scope.
No open issues 🎉
What changed in this PR
This PR revises the eighteen lectures of the QuantEcon "Statistics and Information" part (seven of them appear in this diff) to correct mathematical, statistical, and coding errors, harmonize notation, add cross-links, and add worked exercises with solutions. Several corrections change published figures (e.g., replacing the Jensen–Shannon analysis in wald_friedman with a Kullback–Leibler / average-sample-number treatment).
Changes:
- Fixes math/coding errors and standardizes terminology (e.g., "uniformly most powerful" → "most powerful", corrected KL direction/entropy sign in
divergence_measures, garbling notationM→Qand normalization fixes inpricing_information, noise-free vs. mean-path distinction inmarket_diffusion). - Replaces internal fragile numeric helpers with closed forms (closed-form Beta KL/Chernoff via
betaln/digamma) and replaces hard-coded external URLs with{doc}/{ref}cross-references. - Adds exercises with solutions across the lectures and adds 11 new bibliography entries.
| File | Description |
|---|---|
| lectures/wald_friedman.md | Swaps JS-divergence analysis for KL/average-sample-number, adds Wald bounds/identity derivations and three exercises (incl. VAR misspecification) |
| lectures/wald_friedman_2.md | Adds SPRT-equivalence section, deterministic seeding (seed_numba, seed= arg), ≤/≥ threshold rule, and three exercises |
| lectures/pricing_information.md | Corrects garbling notation/regularity conditions, two_type_revenue pricing logic, solve_menu density normalization, adds ironing exercises |
| lectures/market_diffusion.md | Clarifies equilibrium-value convexity, adds static_equilibrium, renames mean→noise-free path, adds first-passage/generator exercises |
| lectures/imp_sample.md | Clarifies notation (p/q, h), infinite-variance/tail-index discussion, adds effective-sample-size, Hill-estimator, and tilting exercises |
| lectures/gallant_tauchen.md | Aligns MLE/cross-entropy wording with divergence_measures |
| lectures/divergence_measures.md | Fixes entropy sign and KL direction, adds closed forms, data-processing inequality, Chernoff bounds, MLE pseudo-true-value section and three exercises |
| lectures/_static/quant-econ.bib | Fixes Bucklew_2004 indentation and adds new references (Wald–Wolfowitz, Chernoff, Goodfellow, Hill, etc.) |
Review effort: Balanced
…ncies Rename the two exercise labels added to likelihood_ratio_process (lr_ex3, lr_ex4) to lr_ex_markov and lr_ex_lmean, since likelihood_ratio_process_2 already defines and references lr_ex3 and lr_ex4; duplicate explicit targets fail the -W build. Prose fixes found in review: - survival_recursive_preferences: figure text said 20 sample paths; code uses 50. - blackwell_kihlstrom: summary-table row for Chentsov's theorem now matches the corrected body text (invariance under Markov embeddings). - pricing_information: theta* is the type least sure what to do, not the least-informed type, consistent with the note earlier in the lecture. - information_market_equilibrium: lemma hypothesis strengthened to strictly quasi-concave, matching the lemma it relies on. - imp_sample: describe the h_3 estimates as more dispersed rather than more skewed; sample skewness is not informative with infinite variance. - likelihood_var: soften two seed-dependent numbers (alpha_50 about 0.4, error probabilities roughly 0.1). - navy_captain: note that the value-iteration Bayesian loss 11.36 rests on 1,000 Monte Carlo draws and that the simulated loss is near 12.3; drop a code comment implying the old bug was a parallel reduction. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WT8bMXuBemTCPescM41mYa
Review summaryI reviewed all 17 lectures in this PR by re-deriving every claimed correction, executing every code cell (16 of 17 lectures ran with zero cell failures; Bottom line: the mathematics holds up. Every error named in the description was reproduced on Blocking (fixed in cb1f252)
Small prose issues (fixed in cb1f252)
Still open (description only)
Verified corrections (highlights)
Build time
Not verifiedPaper attributions (Borovička proposition numbers, Bergemann–Bonatti–Smolin corollary wording, DeGroot 1962 axioms, Wald/Wallis quotations) and rendered figures. Generated by Claude Code |
📖 Netlify Preview Ready!Preview URL: https://pr-1099--sunny-cactus-210e3e.netlify.app Commit: 📚 Changed Lectures
Build Info
|
- Use {cite:t} where the cited authors are the subject of the
sentence (15 places in 6 lectures). With author_year citations the
hand-typed names rendered twice.
- Replace quoted section names with {ref} links, adding labels to the
five target headings, and drop the redundant {doc} titles in the
navy_captain sentences touched.
- likelihood_var: write transposes as ^\top and drop bold x_t, y_t
(qe-math-002, qe-math-004).
- exchangeable: one sentence per paragraph in the exercise hint.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Style-guide passI checked the PR against the QuantEcon style guide. I ran the deterministic scanner from Pushed in 9242534
Rendering note: for three or more authors, How this was checked: the scanner now reports zero issues for these rules on the edited lines. A full Left for the author (optional)
Checked and fine: line widths and figure sizes follow each lecture's own convention; new main-text figures are captioned and named where their lecture does that; and 🤖 Generated with Claude Code |
|
thanks @thomassargent30! |
A review of the eighteen lectures in the Statistics and Information part found mathematical, statistical and coding errors, several of which changed published figures. This PR corrects them, harmonizes notation, adds cross-links among the lectures, and adds exercises with solutions, including three each to the seven lectures that had none.
Errors that altered results:
@jit(parallel=True), numba miscompiled the boolean-mask assignmentV[wf.π_grid >= A] = wf.L0inside theif flag == 0 ... elseblock ofV_q, zeroing the Bayesian value function, so the fixed-sample versus sequential comparison was 18 vs 0. (The bug is not a race in the reduction: it reproduces with a serial inner loop and with a single thread.) The rewrittenV_qavoids that pattern.Adds 11 bibliography entries.
Follow-up commit cb1f252 renames two exercise labels in likelihood_ratio_process that collided with labels in likelihood_ratio_process_2 (a duplicate-target warning that fails the
-Wbuild) and fixes small prose inconsistencies found in review; see the review comment on this PR for details.🤖 Generated with Claude Code
https://claude.ai/code/session_01WT8bMXuBemTCPescM41mYa