Repository navigation
ci(harness): restore-round-trip uploads no github-pages artifact (#27) - #309
Merged
Merged
Conversation
restore-round-trip (#306) uploaded the restored site with publish-gh-pages' mode: upload and downloaded the github-pages artifact back by name. So does publish-modes, in the same run, so each download could return the other job's artifact. On main (run 42911209128) restore-round-trip read publish-modes' artifact and failed; publish-modes passes on either, since both hold ./index.html, so its check could be met by the wrong upload. restore-round-trip now only restores: diff -r already shows each restore gives back the exact site. publish-modes keeps the run's only github-pages artifact. The hand-off templates/restore.yml makes to publish-gh-pages is tested in the canary, at the next release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WT8bMbZoC2dpGt3sPyBjyd
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The change removes the cross-job github-pages artifact round-trip that was causing CI flakiness from ambiguous downloads, while retaining existing validation and updating testing documentation accordingly.
No open issues 🎉
What changed in this PR
Fixes CI harness flakiness caused by ambiguous github-pages artifact downloads when multiple jobs upload artifacts with the same name in a single workflow run.
Changes:
- Remove the
github-pagesartifact upload/download round-trip fromrestore-round-trip, relying on its existingdiff -rvalidation. - Keep
publish-modesas the run’s onlygithub-pagesartifact producer so its validation refers to its own upload. - Update developer testing docs to reflect that the restore→publish hand-off is covered by the canary rather than the harness job.
| File | Description |
|---|---|
| docs/dev/TESTING.md | Updates the developer testing matrix to indicate the restore→publish hand-off is validated via the canary rather than the harness job. |
| .github/workflows/test-actions.yml | Removes the github-pages artifact round-trip from restore-round-trip to eliminate cross-job artifact name collisions while keeping restore validation. |
Review effort: Balanced
mmcky
added a commit
that referenced
this pull request
Nov 11, 2026
Brings in #308 (PLAN) and #309 (restore-round-trip). No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WT8bMYFuqCc4A8Y1tGJoXT
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action harness has been red on
mainsince #306 merged (run 42911209128). The failing job wasrestore-round-trip: "the github-pages artifact holds no ./sub/a page.html". The action is fine. The test is flaky.Why
restore-round-triphanded the restored site topublish-gh-pages'mode: upload, then downloaded thegithub-pagesartifact back by name.publish-modesdoes the same in the same run. Both uploads succeeded, a second apart: artifact 13807796278 (290 bytes,publish-modes) and 13807297206 (360 bytes,restore-round-trip). So each download can return the other job's artifact. Onmain,restore-round-tripdownloadedpublish-modes' artifact.publish-modespasses on either, since both hold./index.html, so its check could be met by the wrong upload.Changes
.github/workflows/test-actions.ymlrestore-round-tripno longer uploads or downloads agithub-pagesartifact. Itsdiff -ralready shows each restore gives back the exact site. The job's comment says why, and its name drops "and publish-gh-pages takes it".publish-modeskeeps the run's onlygithub-pagesartifact, so its check is about its own upload againdocs/dev/TESTING.mdrestore-gh-pages' row: the hand-off topublish-gh-pagesmoves to the canary, beside the real releases APIThe hand-off
templates/restore.ymlmakes is tested end to end in the canary at the next release: it restorespublish-staged-v0180after a gate run, as agreed on #27. That run is the release's own, not this PR's. The YAML parses andgenerate-docs.py --checkpasses; the gate's actionlint runs on this PR. It is CI-only, so there's no CHANGELOG entry. The maintainer chose this fix on 2026-11-10.Part of #27.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WT8bMbZoC2dpGt3sPyBjyd