Skip to content

preview-workers: the pilot checks for the first lecture repository that adopts it #299

Open

Description

@mmcky

preview-workers (#298, for #145) previews a pull request on a Cloudflare Worker. It is tested in this repository's harness, which has no Cloudflare account, and on the canary's own Worker, qe-preview-canary. Five things in #145's "Verify during pilot" list can only be checked once a real lecture repository uses it. The maintainer decided on 2026-11-10 that #145 closes with the action, and these move here for the first lecture repository that adopts it.

  • Limits per Worker version. Static assets have a file-count limit and a 25 MiB per-file limit per version. Check them against the largest site's _build/html. It's unclear whether Workers got the larger file count that Pages received in January 2026. The lecture sites publish through GitHub's Pages deploy, so no gh-pages tree exists to count from here.
  • Version retention. How long old versions and their aliased URLs persist, and how they are pruned. This differs from Pages deployments.
  • Alias stability across many pushes to one pull request, and what happens when two uploads race. The concurrency cancellation from Optimize preview builds: phased plan for the fastest PR previews (tracking) #92's phase 1 should be in the repository's workflow first.
  • The trust gate on a real repository. Fork and Dependabot pull requests must deploy nothing, as with the other two preview actions (scripts/preview-decide.sh).
  • Optional: Cloudflare Access in front of preview URLs, which works on workers.dev previews, for a repository that needs gated drafts. preview-workers has no visibility input for now. Adding the check later, as an input that defaults to off, would break no caller.

The canary run of #298 covers a pull request's placeholder and deploy, a second push to the same alias, a dispatch alias, and a wrong account-subdomain failing, on one small site. It doesn't cover the items above.

Claude Code (on behalf of mmcky), organiser session

Activity

  1. added
    enhancementImprovement to existing content or functionality
    on Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementImprovement to existing content or functionality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions