You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Keep deploy credentials out of the jobs that execute notebooks #239
Goal: no workflow template in this repository runs notebook or repository code in a job that holds a deploy credential, a Pages or OIDC permission, or a persisted checkout token.
Where we stand (verified 2026-11-04)
Next:#232. Start from the checkout and deploy steps in templates/ci.yml:46-96; the two-job shape and the done-when are in the issue.
Nothing is in flight. Both work items are open and unassigned.
Plan
The work items and their order are the sub-issues below. The top one is next, and completed items keep their place.
Sequencing rationale: the preview split ranks first. The credential it protects is a long-lived provider token, which every repository that copies the preview template inherits. The publish split protects a short-lived Pages OIDC capability instead. It applies the same build and deploy split and needs nothing the preview split produces, so its place in the order is a preference, not a gate.
The integrity of the site's content. The build produces the deployed files either way: this project isolates credentials, not content.
The other findings of the 2026-10-06 codebase review. Their dispositions are in .qe/dev/log/2026-10-06-codebase-review.md (qe: record the 2026-10-06 codebase review (QEP-7) #220), and every issue filed from it opens with "From the 2026-10-06 codebase review".
2026-11-04: created from the 2026-10-06 codebase review (record: .qe/dev/log/2026-10-06-codebase-review.md, #220), by a local agent carrying out .qe/dev/log/2026-10-06-github-handover.md (#221).
The review's fifteen findings were each checked against the code and searched for in existing issues and pull requests. This project is finding M1, deploy credentials sharing a job with notebook execution, as two work items: #232 and #233.
The review's other new work does not share this goal, so it was filed as standalone issues:
Both sub-issues are done, so this tracker's goal holds on main: no workflow template runs notebook or repository code in a job that holds a deploy credential, a Pages or OIDC permission, or a persisted checkout token.
Both are unreleased. #257's mode reaches @v0 consumers in the next staged release, and until then the new templates/publish.yml needs that release, as #257 says. Closed with the maintainer's approval.
Claude Code (on behalf of mmcky), organiser session
Activity
mmcky commentedon Nov 4, 2026
2026-11-04: created from the 2026-10-06 codebase review (record:
.qe/dev/log/2026-10-06-codebase-review.md, #220), by a local agent carrying out.qe/dev/log/2026-10-06-github-handover.md(#221).The review's fifteen findings were each checked against the code and searched for in existing issues and pull requests. This project is finding M1, deploy credentials sharing a job with notebook execution, as two work items: #232 and #233.
The review's other new work does not share this goal, so it was filed as standalone issues:
Of the remaining findings:
${{ }}expressions inrun:scripts intoenv:(PLAN item 18) #228, filed on 2026-11-04 fromdocs/dev/PLAN.mdbacklog item 18;qe: record the outcome of the 2026-10-06 GitHub handover
qe: handover for the GitHub follow-ups of the 2026-10-06 review, and …
feat(templates): deploy the pull request preview from a job that runs…
feat(templates): deploy the pull request preview from a job that runs…
feat(templates): deploy the pull request preview from a job that runs…
feat(templates): deploy the pull request preview from a job that runs…
feat(publish-gh-pages): a mode input, so Pages is deployed from a job…
feat(publish-gh-pages): a mode input, so Pages is deployed from a job…
mmcky commentedon Nov 5, 2026
Both sub-issues are done, so this tracker's goal holds on
main: no workflow template runs notebook or repository code in a job that holds a deploy credential, a Pages or OIDC permission, or a persisted checkout token.cf791ae):templates/ci.ymlbuilds in one job and deploys the preview from another that runs no repository code, and every template's checkout setspersist-credentials: false.0ce36c9):publish-gh-pagesgainsmode(all,upload,deploy,release), andtemplates/publish.ymlbuilds withcontents: readand deploys from a job holding onlypages: writeandid-token: write. Release assets get a job of their own.Both are unreleased. #257's
modereaches@v0consumers in the next staged release, and until then the newtemplates/publish.ymlneeds that release, as #257 says. Closed with the maintainer's approval.Claude Code (on behalf of mmcky), organiser session
docs(manual): the cross-cutting chapters, and signposts for the templ…