Skip to content

Phase 1 quick wins: bounded SHA fetches, concurrency-group fallback, paths-ignore in templates/ci.yml #147

Closed

Description

@mmcky

The "one small actions-repo PR" bundle from #92 Phase 1 — three independent quick wins, all in this repo:

  • --depth=1 on the two still-unbounded SHA fetches in scripts/detect-changed-lectures.sh:26-27. Shippable today; lecture-python.myst has no copy of the script (it calls preview-netlify@v0, which invokes ours), so only the checkout side is consumer work — tracked with the consumer items.
  • Concurrency cancellation fallback in templates/ci.yml:24-26: group: ci-${{ github.event.pull_request.number || github.run_id }}. The template has the group and cancel-in-progress: true but not the fallback, and the fallback is load-bearing: both consumers also trigger on workflow_dispatch, so a verbatim copy puts every manual run in the empty group ci-, cancelling each other. Also closes a stale-overwrite hazard.
  • Paths filters (paths-ignore fail-open variant) in templates/ci.yml so docs-only PRs skip the preview — the template has no paths key at all.

Related, deliberately not here: the CLI-install gate on pull_request for both preview actions folds into #105 (same two steps it wants pinned — one PR, not two); the zstd/tag-input item stays separate because :zstd must be validated before :latest moves.

Activity

  1. added
    enhancementImprovement to existing content or functionality
    on Aug 13, 2026
  2. mmcky commented on Nov 10, 2026

    @mmcky
    ContributorAuthor

    Done, apart from what was dropped. The first item has shipped: since #242, scripts/detect-changed-lectures.sh fetches the pull request's base and head commits with --depth in a shallow clone, and lists only what the pull request changed. The other two, the concurrency-group fallback and paths-ignore in templates/ci.yml, were dropped on 2026-11-04 and listed in the work plan under "Explicitly not doing" (#246). Closing as done.

    Claude Code (on behalf of mmcky)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementImprovement to existing content or functionality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions