Repository navigation
[429] Fix validation of subsequent event records - #431
Draft
ANAMASGARD wants to merge 1 commit into
Draft
ANAMASGARD wants to merge 1 commit into
ANAMASGARD wants to merge 1 commit into
Conversation
Validate each newly created event instead of repeatedly checking the list head. Reset daily planting and harvest flags before leaf-event handling returns so that valid events on a new date are not rejected. Add 51 reader regression cases covering calculated phenology, same-day conflicts, date transitions, input errors, and validation state across files.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 51 reader regression cases covering phenology conflicts, event ordering, date transitions, malformed input, and validation state between files.
How was this change tested?
make cleanall
make -j4
make test
make testrun
Reproduction steps
Run the reproductions in #429. Incompatible leaf events now exit 3, same-day planting/harvest exits 5, and valid day-transition sequences succeed.
Related issues
Checklist