Repository navigation
[#421] Fix missed event detection across year boundaries - #428
Open
ANAMASGARD wants to merge 2 commits into
Open
ANAMASGARD wants to merge 2 commits into
ANAMASGARD wants to merge 2 commits into
Conversation
ANAMASGARD
requested review from
Alomir,
dlebauer,
mdietze and
mswilburn
as code owners
October 28, 2026 16:41
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Collaborator
|
@ANAMASGARD Please resolve the branch conflicts for this PR, and bring it back to ready-for review. Thanks! |
Contributor
Author
|
@Alomir can you please re review it i have resolved the conflict . Thanks |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(year, day)dates in carbon processing, nitrogen processing, and event output using a shared helper.5.Valid event schedules and output formats remain unchanged. New tests are in
tests/sipnet/test_events_infrastructure, as requested.How was this change tested?
5; removing the missed event allows the later tillage to run with exit0.make test(29 unit executables passed), andmake testrunpassed.clang-format,clang-tidy, andgit diff --checkpassed.Reproduction steps
Run the reproducer in #421, which uses:
2016/100, then2017/10.2016/200, then2017/10.Before: Exit
0, with neither event written toevents.out.After: Exit
5, reporting that event2016/200has no matching climate record when climate reaches2017/10.Related issues
Checklist
docs/CHANGELOG.mdupdated.clang-format.