Repository navigation
[#416] Remove clamping from balance checks - #425
Open
priyanshusky0 wants to merge 2 commits into
Open
priyanshusky0 wants to merge 2 commits into
priyanshusky0 wants to merge 2 commits into
Conversation
priyanshusky0
requested review from
Alomir,
dlebauer,
mdietze and
mswilburn
as code owners
October 28, 2026 05:27
priyanshusky0
added a commit
to priyanshusky0/sipnet
that referenced
this pull request
Oct 28, 2026
Collaborator
|
@priyanshusky0 Please resolve the branch conflicts for this PR, thanks! |
ensureNonNegative now exits on real violations, so the balance tracker no longer needs to account for mass added by clamping. Drop the clamped and final totals, take the post-update totals after ensureNonNegativeStocks(), and compute system inputs and outputs in updateBalanceTrackerPostUpdate(). Widen the balance tolerance to 10 * EPS to allow for several sub-EPS stocks being zeroed in the same step.
priyanshusky0
force-pushed
the
416-remove-balance-clamping
branch
from
November 5, 2026 12:38
d0910e7 to
5cf89ab
Compare
Contributor
Author
|
@Alomir Rebased onto master, conflicts resolved, and CI is passing. Ready for review, thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateBalanceTrackerPostUpdate()to afterensureNonNegativeStocks(), replacingupdateBalanceTrackerPostClamp().As discussed in #416, the balance tolerance is now
10 * EPSto allow for small rounding adjustments adding up within a step.This is built on top of #414, so that commit will show here until #414 is merged.
How was this change tested?
make unitandmake smokepass, no smoke output changesRelated issues
Checklist
docs/CHANGELOG.mdupdated with noteworthy changesclang-format