Skip to content

SIP[N/A] New test cleanup with new failure tracker module - #419

Merged
Alomir merged 2 commits into
masterfrom
SIPxxx-test-cleanup
Oct 26, 2026
Merged

Alomir merged 2 commits into
masterfrom
SIPxxx-test-cleanup

Conversation

@Alomir

@Alomir Alomir commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • What: Quick cleanup/modularization pass on new tests

The new FailureTracker module can be used in any future large-case-matrix tests like testLimitations and testCompleteHarvest. It might be useful to update some existing tests to use it (but most don't need it).

How was this change tested?

No functionality changes, all tests pass

Related issues

  • Fixes (N/A)

Checklist

  • Related issues are listed above. PRs without an approved, related issue may not get reviewed.
  • PR title has the issue number in it ("[#] <concise description of proposed change>")
  • Tests added/updated for new features (if applicable)
  • Documentation updated (if applicable)
  • docs/CHANGELOG.md updated with noteworthy changes
  • Code formatted with clang-format (run git clang-format if needed)

Note: See CONTRIBUTING.md for additional guidance. This repository uses automated formatting checks; if the pre-commit hook blocks your commit, run git clang-format to format staged changes.

@Alomir Alomir changed the title SIPxxx Cleanup with new failure tracker module SIP[N/A] New test cleanup with new failure tracker module Oct 24, 2026
@Alomir
Alomir marked this pull request as ready for review October 24, 2026 16:08
Copilot AI balanced review requested due to automatic review settings October 24, 2026 16:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new helper is missing from GNU Make prerequisites, so edits to it can leave both test executables stale.

1 open issue
What changed in this PR

This PR consolidates failure tracking for two large test suites into a reusable helper, without changing production model code.

Changes:

  • Extracts assertion checks, failure counting, debug pauses, and final status reporting into failureTracker.c.
  • Migrates the limitation and complete-harvest tests to the helper, with debug pauses disabled by default.
  • Adds the tests and helper to the CMake IDE project listing.
File Description
tests/​utils/​failureTracker.c Adds reusable failure tracking and reporting.
tests/​sipnet/​test_modeling/​testLimitations.c Replaces local failure handling with the shared helper.
tests/​sipnet/​test_modeling/​testCompleteHarvest.c Adopts shared tracking and disables default debug pauses.
CMakeLists.txt Registers both tests and the helper for IDE support.

Review effort: Balanced

Comment thread tests/utils/failureTracker.c Resolved
@Alomir
Alomir merged commit 694b3ac into master Oct 26, 2026
12 checks passed
@Alomir
Alomir deleted the SIPxxx-test-cleanup branch October 26, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants