Repository navigation
SIP[N/A] New test cleanup with new failure tracker module - #419
Merged
Merged
Conversation
Alomir
marked this pull request as ready for review
October 24, 2026 16:08
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new helper is missing from GNU Make prerequisites, so edits to it can leave both test executables stale.
1 open issue
What changed in this PR
This PR consolidates failure tracking for two large test suites into a reusable helper, without changing production model code.
Changes:
- Extracts assertion checks, failure counting, debug pauses, and final status reporting into
failureTracker.c. - Migrates the limitation and complete-harvest tests to the helper, with debug pauses disabled by default.
- Adds the tests and helper to the CMake IDE project listing.
| File | Description |
|---|---|
tests/utils/failureTracker.c |
Adds reusable failure tracking and reporting. |
tests/sipnet/test_modeling/testLimitations.c |
Replaces local failure handling with the shared helper. |
tests/sipnet/test_modeling/testCompleteHarvest.c |
Adopts shared tracking and disables default debug pauses. |
CMakeLists.txt |
Registers both tests and the helper for IDE support. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The new FailureTracker module can be used in any future large-case-matrix tests like
testLimitationsandtestCompleteHarvest. It might be useful to update some existing tests to use it (but most don't need it).How was this change tested?
No functionality changes, all tests pass
Related issues
Checklist
docs/CHANGELOG.mdupdated with noteworthy changesclang-format(rungit clang-formatif needed)Note: See CONTRIBUTING.md for additional guidance. This repository uses automated formatting checks; if the pre-commit hook blocks your commit, run
git clang-formatto format staged changes.