Repository navigation
fix(utils): quiet read.output defaults - #4163
Conversation
|
Hi @divine7022,@dlebauer, Could you please take a look when you get a chance and let me know if any changes are needed? |
|
@tyagivibhor111-hub How did you decide who to tag here? |
Hi @infotroph, sorry for the confusion. I mistakenly thought the issue was raised by @divine7022 because I had worked on one of their issues before. I got confused while tagging, my apologies for that. |
|
@infotroph, could you please review (#4163) when you get a chance? The checks are passing, and I’ve tested the changes with 41 passed and 0 failed. I’ve also preserved the important warnings and diagnostics while making routine informational messages conditional on |
|
@infotroph, could you please review #4163 when you get a chance and let me know if any changes are needed? |
| expect_true(any(grepl("No start or end year provided", verbose_log))) | ||
| expect_true(any(grepl("Reading the following files", verbose_log))) | ||
| expect_true(any(grepl("Variables not specified", verbose_log))) |
There was a problem hiding this comment.
use expect_match here as the above block was doing before
There was a problem hiding this comment.
ok @infotroph , I’ll replace these expect_true(any(grepl(...))) assertions with expect_match, as suggested.
There was a problem hiding this comment.
@infotroph ,Updated the assertions to use expect_match() as suggested. The test file passes locally.
Commit: cfc23a9
Description
This PR makes
read.output()quieter by default to reduce unnecessary informational messages during normal execution.Previously,
read.output()printed a summary by default and emitted informational messages about reading output for all years, listing NetCDF files, and reading all variables. These messages can make the output noisy when users do not need detailed logging.This change disables summary printing by default and displays these routine informational messages only when
verbose = TRUE. Important warnings and diagnostics, including invalid or missing origin-year warnings and missing output-file messages, are preserved.Issue #3996
Changes Made
print_summaryfromTRUEtoFALSE.verbose = TRUE.read.output()documentation to reflect the new default behavior.print_summary = TRUE.Testing
test-read.output.Rusingtestthat.git diff --check; no whitespace errors were reported.Type of Change
Checklist