Repository navigation
docs: make the quickstart examples run in order - #570
Merged
Merged
Conversation
The regression example rebound X_train/y_train, so the following config example fitted a classifier on continuous targets, and the LSS example started with an "X_train, ... = ..." placeholder that raises TypeError. Keep the regression split in its own *_reg variables and reuse it in the LSS example. Fixes #569
mkumar73
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #569
Problem
Running the quickstart's python blocks in order failed twice:
MambularClassifieron continuous targets (InvalidDataError);X_train, X_test, y_train, y_test = ...(TypeError: cannot unpack non-iterable ellipsis object).Change
Docs only,
docs/getting_started/quickstart.md:X_reg/y_regandX_train_reg/X_test_reg/y_train_reg/y_test_reg.The other examples are unchanged.
Verification
All quickstart code blocks now run in order in one session (1 epoch, CPU). The only exception is the illustrative inference fragments with a placeholder
X_new, which this PR doesn't touch.Checks
just test: 3236 passed, 46 skipped, 28 xfailed; coverage 91.29%just docs: build succeeded (warnings treated as errors)just check: all hooks passed (ruff, prettier, pyright)