Repository navigation
docs: use numerical_method="none" to disable numerical preprocessing - #550
Merged
Merged
Conversation
The configuration guide said numerical_method=None turns off the numerical transform, but None keeps PreTab's default representation (PLE); the string "none" is the no-op. Fix the field table, the "Running with no numerical preprocessing" example and the None/"none" warning. Fixes #549
The note after the example still recommended None for already-scaled features, and the field table did not mention that a preset changes the default representation. Refs #549
mkumar73
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #549
Problem
docs/core_concepts/config_system.mdtold readers to passnumerical_method=Noneto turn off numerical preprocessing. ThePreprocessingConfigfield table said "PassNonefor no transform", and the "Running with no numerical preprocessing" section usednumerical_method=Nonein an example commented# no scaling, binning, or PLE on numeric columns. The boxes below that example built on the same premise.Noneactually keeps PreTab's default representation (PLE withoutput_dimcolumns per feature, unless apresetchooses another). The no-op is the string"none". ThePreprocessingConfigdocstring was already correct.Change
Docs only, in
docs/core_concepts/config_system.md:Nonekeeps the default ("ple", or thepreset's choice) and"none"disables the transform.numerical_method="none", and say explicitly that leavingNonekeeps PLE unless apresetchooses another representation.importantandnoteboxes refer to"none", and thewarningbox now explains the difference from the"none"side.Verification
I ran the updated example against
main. WithPreprocessingConfig(numerical_method="none", categorical_method=None), the numerical pipeline isimputer -> noop, whereasnumerical_method=Nonegivesimputer -> minmax -> plewith width 7. Withpreset="standard",Noneresolves to the preset's B-spline representation, hence the preset caveat.Checks
just test: 3236 passed, 46 skipped, 28 xfailed; coverage 91.29%just docs: build succeeded (warnings treated as errors)just check: all hooks passed (ruff, prettier, pyright)