Repository navigation
Fix XmlDocument.getDocumentBuilder to preserve XML comments on parse - #557
Merged
venmanyarun merged 1 commit intoOct 8, 2026
Conversation
Commit 28cfab5 refactored createDocument(File) to use the shared getDocumentBuilder() factory which had setIgnoringComments(true). This caused XML comments (e.g. <!--replaceable-->) to be stripped from server.xml when it was parsed and written back during generate-features, breaking the generate-features integration tests. Set setIgnoringComments(false) in getDocumentBuilder() to restore the original behaviour of preserving comments during document parse/write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 28cfab5 refactored createDocument(File) to use the shared getDocumentBuilder() factory which had setIgnoringComments(true). This caused XML comments (e.g. ) to be stripped from server.xml when it was parsed and written back during generate-features, breaking the generate-features integration tests.
Set setIgnoringComments(false) in getDocumentBuilder() to restore the original behaviour of preserving comments during document parse/write.