Repository navigation
ci(mac): build, smoke-test and release the mac app - #7
Open
OleanjiKingCode wants to merge 3 commits into
Open
OleanjiKingCode wants to merge 3 commits into
OleanjiKingCode wants to merge 3 commits into
Conversation
OleanjiKingCode
marked this pull request as ready for review
November 9, 2026 16:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Nothing builds the Mac app on GitHub. A pull request that breaks the build, or drops a sprite from the app, is found only when someone builds it by hand. Three open pull requests touch
mac/(#2, #5, #6) and none of them gets a check. A reviewer also has no app to download and try.Change
.github/workflows/mac.yml(new). On pull requests and pushes tomainthat touchmac/:mac/release.sh, which builds one binary for Apple silicon and Intel and zips it asdist/ScreenCat-mac-<version>.zip, and fails unlesslipo -archsshows both;Cat_Shadow.png,Cat_Ball.png,Dog_Ball.png,AppIcon.icns,CREDIT.txt) is inside the app, then draws every clip with--previewand fails if no sheet is written. Running outside the repo stops the app finding the art inmac/Assetswhen the bundle lacks it;ScreenCat-macand the sheet asScreenCat-mac-preview.v1.2.0givesScreenCat-mac-1.2.0.zip, the same name as the v1.1.0 asset). This matches the release job inwindows.ymlon feat(windows): windows port at parity with the mac app #3.build.sh,release.shand the app code. No signing or notarizing, which still needs an Apple Developer ID.Checks
release.shgivesScreenCat-mac-1.1.0.zipwithx86_64 arm64; the preview step passes on a good build, fails with "missing from the app: Cat_Shadow.png" when that file is taken out, and fails when the sheet is taken out even withmac/Assetspresent.ScreenCat-mac.