Skip to content

ci(mac): build, smoke-test and release the mac app - #7

Open
OleanjiKingCode wants to merge 3 commits into
mainfrom
ci/mac-build
Open

OleanjiKingCode wants to merge 3 commits into
mainfrom
ci/mac-build

Conversation

@OleanjiKingCode

@OleanjiKingCode OleanjiKingCode commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Why

Nothing builds the Mac app on GitHub. A pull request that breaks the build, or drops a sprite from the app, is found only when someone builds it by hand. Three open pull requests touch mac/ (#2, #5, #6) and none of them gets a check. A reviewer also has no app to download and try.

Change

  • .github/workflows/mac.yml (new). On pull requests and pushes to main that touch mac/:
    • runs mac/release.sh, which builds one binary for Apple silicon and Intel and zips it as dist/ScreenCat-mac-<version>.zip, and fails unless lipo -archs shows both;
    • from outside the repo, checks that every art file (the cat and dog sheets, Cat_Shadow.png, Cat_Ball.png, Dog_Ball.png, AppIcon.icns, CREDIT.txt) is inside the app, then draws every clip with --preview and fails if no sheet is written. Running outside the repo stops the app finding the art in mac/Assets when the bundle lacks it;
    • uploads the zip as ScreenCat-mac and the sheet as ScreenCat-mac-preview.
  • On a published release, a second job, the only one with write access, attaches the zip to the release. The version comes from the tag (v1.2.0 gives ScreenCat-mac-1.2.0.zip, the same name as the v1.1.0 asset). This matches the release job in windows.yml on feat(windows): windows port at parity with the mac app #3.
  • Left alone: build.sh, release.sh and the app code. No signing or notarizing, which still needs an Apple Developer ID.

Checks

  • Ran the same steps on this Mac: release.sh gives ScreenCat-mac-1.1.0.zip with x86_64 arm64; the preview step passes on a good build, fails with "missing from the app: Cat_Shadow.png" when that file is taken out, and fails when the sheet is taken out even with mac/Assets present.
  • CI on the first commit passed. Self-review (standards and spec) found the preview gap and the duplicated build steps, fixed in the second commit; a re-review found the dog art and icon unchecked, fixed in the third.
  • To try: open the Actions run on this pull request and download ScreenCat-mac.

@OleanjiKingCode OleanjiKingCode added the low priority Polish, cleanup, refactors label Nov 8, 2026
@OleanjiKingCode OleanjiKingCode changed the title [NOT READY] ci(mac): build and preview the app on every pull request [NOT READY] ci(mac): build, smoke-test and release the mac app Nov 8, 2026
@OleanjiKingCode OleanjiKingCode changed the title [NOT READY] ci(mac): build, smoke-test and release the mac app ci(mac): build, smoke-test and release the mac app Nov 9, 2026
@OleanjiKingCode
OleanjiKingCode marked this pull request as ready for review November 9, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low priority Polish, cleanup, refactors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant