Skip to content

cmd: add proposer config seed file - #4838

Open
KaloyanTanev wants to merge 5 commits into
kalo/proposer-config-edit-cmdfrom
kalo/proposer-config-seed-file
Open

KaloyanTanev wants to merge 5 commits into
kalo/proposer-config-edit-cmdfrom
kalo/proposer-config-seed-file

Conversation

@KaloyanTanev

@KaloyanTanev KaloyanTanev commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Operators had to retype the same --proposer-config-* flags to seed a cluster's first signed proposer config, and a single typo fails the DKG. A cluster creator who runs no node could not set those values at all.

  • charon create dkg takes the --proposer-config-* flags and writes proposer-config-seed.json next to cluster-definition.json.
  • charon dkg and charon create cluster take --proposer-config-seed-file (path or HTTP URL) as an alternative to the flags, never both.

The file is the version and default_config of the proposer config file, without fee recipients, which stay in the definition.

category: feature
ticket: #4324

@KaloyanTanev KaloyanTanev self-assigned this Nov 12, 2026
@github-actions github-actions Bot added the branch-invalid PR raised against invalid branch. Not a main or release branch. label Nov 12, 2026
@KaloyanTanev
KaloyanTanev added this pull request to stack #4832 November 12, 2026 12:09
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (kalo/proposer-config-edit-cmd@cbdc4d9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cluster/helpers.go 85.71% 2 Missing ⚠️
cluster/proposerconfig/seed.go 96.22% 2 Missing ⚠️
cmd/createdkg.go 96.77% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##             kalo/proposer-config-edit-cmd    #4838   +/-   ##
================================================================
  Coverage                                 ?   69.09%           
================================================================
  Files                                    ?      268           
  Lines                                    ?    35485           
  Branches                                 ?        0           
================================================================
  Hits                                     ?    24518           
  Misses                                   ?    10966           
  Partials                                 ?        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@KaloyanTanev
KaloyanTanev marked this pull request as ready for review November 12, 2026 15:31
@KaloyanTanev
KaloyanTanev force-pushed the kalo/proposer-config-seed-file branch from 80ace1b to 29c7aeb Compare November 17, 2026 09:54
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch-invalid PR raised against invalid branch. Not a main or release branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants