Repository navigation
[FIX] api_log: log exceptions whose headers are None - #666
Merged
Merged
Conversation
Contributor
|
Hi @paradoxxxzero, |
This was referenced Oct 19, 2026
lmignon
approved these changes
Oct 20, 2026
Contributor
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 7e4e97a. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_prepare_log_exceptiononly initializes the headers when the exception has noheadersattribute. Starlette/FastAPIHTTPExceptionalways have it, but it isNonewhen raisedwithout headers (404, 422...), so
_inject_log_entryfails with:With
fastapi_logenabled on an endpoint, every error response logs a warning with its traceback and theapi.logrecord is left without its stack trace.The check now also covers
headersset toNone. Since the headers are set on the exception,fastapi_log._prepare_log_exception(which readsexception.headersfor Starletteexceptions) works too.
Added
test_log_exception_none_headers: it fails with theTypeErrorabove without the fix.18.0 has the same issue:
getattr(exception, "headers", {})returnsNonewhen the attribute exists.