Skip to content

misc/*.keymap: fix menu Home and End key bindings - #5181

Merged
zyv merged 1 commit into
masterfrom
feature/fix-home-end-keymap
Oct 11, 2026
Merged

zyv merged 1 commit into
masterfrom
feature/fix-home-end-keymap

Conversation

@zyv

@zyv zyv commented Oct 10, 2026

Copy link
Copy Markdown
Member

Proposed changes

The [menu] section of the shipped keymaps contains two typos: ctr-a instead of ctrl-a and a missing separator between alt-gt and ctrl-e. As a result, C-a and C-e don't work in dropdown menus when a keymap file is loaded, although they do with the built-in defaults (--nokeymap), which already have home; alt-lt; ctrl-a and end; alt-gt; ctrl-e.

Introduced in f5f78ea .

Checklist

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

The [menu] section of the shipped keymaps contains two typos: `ctr-a`
instead of `ctrl-a` and a missing separator between `alt-gt` and
`ctrl-e`. As a result, C-a and C-e don't work in dropdown menus when
a keymap file is loaded, although they do with the built-in defaults
(`--nokeymap`), which already have `home; alt-lt; ctrl-a` and
`end; alt-gt; ctrl-e`.

Introduced in f5f78ea .

Assisted-By: Claude Opus 5.5
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
@github-actions github-actions Bot added the needs triage Needs triage by maintainers label Oct 10, 2026
@github-actions github-actions Bot added this to the Future Releases milestone Oct 10, 2026
@github-actions github-actions Bot added the prio: medium Has the potential to affect progress label Oct 10, 2026
@zyv
zyv requested a review from mc-worker October 10, 2026 19:17
@zyv zyv modified the milestones: Future Releases, 4.9.0 Oct 10, 2026
@zyv zyv added area: keybind Key bindings and removed needs triage Needs triage by maintainers labels Oct 10, 2026
@zyv

zyv commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

@tuffnatty inspired by your #5165

@tuffnatty

Copy link
Copy Markdown
Contributor

lgtm

@zyv

zyv commented Oct 11, 2026

Copy link
Copy Markdown
Member Author

Thank you, guys!

@zyv
zyv merged commit 32e3114 into master Oct 11, 2026
19 checks passed
@zyv
zyv deleted the feature/fix-home-end-keymap branch October 11, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: keybind Key bindings prio: medium Has the potential to affect progress

Development

Successfully merging this pull request may close these issues.

3 participants