Skip to content

call_js_keyword: Get the timeout property only if defaultTime is not in args - #5564

Open
mardukbp wants to merge 1 commit into
MarketSquare:mainfrom
mardukbp:fix-call_js_keyword
Open

mardukbp wants to merge 1 commit into
MarketSquare:mainfrom
mardukbp:fix-call_js_keyword

Conversation

@mardukbp

Copy link
Copy Markdown
Contributor

In the following code

args.setdefault("defaultTimeout", int(self.timeout))

self.timeout is called whether defaultTimeout is in args or not. This property throws an exception when call_js_keyword is called from the __init__ method of a plugin.

The fix in this PR only calls self.timeout if defaultTimeout is not in args. This allows passing a default timeout when calling call_js_keyword in the plugin constructor.

@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant