Repository navigation
fix: route Huawei/Motorola adb PIDs through adb labels - #365
Merged
Merged
Conversation
Bare SYMLINK+="android_adb" lines in the Huawei and Motorola sections never reached LABEL="android_usb_rule_match": both sections end with GOTO="android_usb_rules_end", so MODE="0660", GROUP="adbusers" and TAG+="uaccess" were not applied. Use GOTO="adb" instead. Huawei 12d1:107e was listed twice (P10 Lite, Mate 9); the second line was unreachable. Merged into one GOTO="adbmtp" line, matching the reported mtp+mass_storage+adb composition of LYA-L29 (Mate 20 Pro). Fixes #364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #364.
Bare
SYMLINK+="android_adb"lines in the Huawei and Motorola sections never reachedLABEL="android_usb_rule_match": both sections terminate withGOTO="android_usb_rules_end", which jumps past theENV{adb_user}=="yes", MODE="0660", GROUP="adbusers", TAG+="uaccess"line. Only the symlink was applied. Replaced withGOTO="adb"(sameandroid_adbsymlink, plus mode/group/uaccess).Affected PIDs: Huawei
1050,103a,107d; Motorola2d66,428c,41db. An audit of every vendor section (guard ->LABEL="not_X", terminator, assignment lines withoutGOTO) found no other section with this shape.12d1:107ewas listed twice (P10 Lite, Mate 9); the second line was unreachable. Merged into oneGOTO="adbmtp"line, matching the composition reported for LYA-L29 (Mate 20 Pro): MTP + mass storage + ADB interface.udevadm verify 51-android.rules: Success 1 / Fail 0. No12d1:107edevice available, so no runtimeudevadm test.