Repository navigation
Prevent builds from getting moved to dynamic groups - #4095
Merged
williamjallen merged 2 commits intoOct 20, 2026
Merged
Conversation
Collaborator
Author
|
Looking for a double review on this. @josephsnyder, a standard review. @zackgalbreath, a brief check to make sure the big-picture idea makes sense. |
josephsnyder
approved these changes
Oct 9, 2026
Builds are supposed to be assigned to exactly one "regular" build group, and dynamic build groups are supposed to have no associated builds. Various parts of the codebase are inconsistent about this, and unintentionally make it seem as if it's possible to reassign builds to dynamic groups. This fixes the issue by adding checks to ensure users can only move builds between "regular" build groups. I plan to follow this with a separate PR which addresses builds which are incorrectly assigned to dynamic groups.
williamjallen
force-pushed
the
no-move-to-dynamic-groups
branch
from
October 19, 2026 02:13
3680667 to
dfcc5ac
Compare
zackgalbreath
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds are supposed to be assigned to exactly one "regular" build group, and dynamic build groups are supposed to have no associated builds. Various parts of the codebase are inconsistent about this, and unintentionally make it seem as if it's possible to reassign builds to dynamic groups. This fixes the issue by adding checks to ensure users can only move builds between "regular" build groups. I plan to follow this with a separate PR which addresses builds which are incorrectly assigned to dynamic groups.