Repository navigation
Faster 3-argument dot - #1367
Open
mateuszbaran wants to merge 2 commits into
Open
mateuszbaran wants to merge 2 commits into
mateuszbaran wants to merge 2 commits into
Conversation
|
18 regressions on an Apple M5 Pro, primarily ComplexF64. |
Collaborator
Author
|
Thanks for testing, I've modified the code to select the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1287 . Selects one of three kernels: a custom SLP-vectorizable kernel,
dot(x, A*y)or the the generic 3-argumentdotimplementation depending on the situation.Here are my benchmark results, though it would be good to run it on other architectures to make sure the parameters are not over-tuned to a single architecture.
dot(x,A*y)seems to bring most of the gains but the custom kernel is still sometimes beneficial.Contribution co-authored by Claude Opus 5.5.