Skip to content

Skip the readiness checks in the SlotSynced test, as its node stops by itself - #6778

Open
palas wants to merge 1 commit into
masterfrom
slot-synced-patch
Open

palas wants to merge 1 commit into
masterfrom
slot-synced-patch

Conversation

@palas

@palas palas commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

There is a recurrent but non-deterministic issue with the SlotSynced test. And it looks like it is caused by a failing readiness check on a node that stops after 150 slots. So this PR modifies the test so that no readiness check is done in that particular test, and we also disable watchdog for that test.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Running tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
    • cardano-node-chairman, cardano-submit-api and cardano-testnet instead need a
      changelog fragment in <package>/.changes/, because their CHANGELOG.md is generated
      from fragments at release time. Copy _TEMPLATE.yml from that directory, or run
      nix run github:input-output-hk/cardano-dev#herald -- new
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@palas palas self-assigned this Nov 21, 2026
@palas
palas requested a review from a team as a code owner November 21, 2026 21:30

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant