Repository navigation
[Gluon] [Triton 3.9 API] Refactor async_copy calls to use async_load for improved performance - #432
Merged
Merged
Conversation
…for improved performance
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new API is unavailable in Triton 3.6.0, which the package still permits, so compatibility handling or an updated minimum dependency is needed.
1 open issue
What changed in this PR
This PR migrates the Gluon SM80 forward attention kernel to Triton’s newer asynchronous load API, aiming to improve performance.
Changes:
- Replaces nine
async_copy_global_to_sharedcalls withasync_load. - Preserves existing load arguments, masking, and synchronization.
| File | Description |
|---|---|
flash_sparse_attn/ops/gluon/flash_fwd_sm80.py |
Migrates asynchronous query, key, and value loads to the newer API. |
Review effort: Balanced
| config, config.copy_row_m_offs(), config.copy_col_k_offs() | ||
| ) | ||
| async_copy.async_copy_global_to_shared( | ||
| async_copy.async_load( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.