Repository navigation
docs(tofu): record the first apply and both proofs as run, and set umask 077 (#445) - #828
Merged
Merged
Conversation
…ask 077 (#445) 998 cloned from 901 into the proof pool; the real state is the encrypted wrapper and holds neither the proof password nor the passphrase; git add is refused and -f is caught; teardown removed the guest, pool, disk and grant. The state was written 664 under the shell's umask, so §4 now sets umask 077 and a 700 state directory first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The roadmap retains a stale #440 status that conflicts with the newly completed dependent work.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Records successful OpenTofu provisioning and encryption proofs while tightening state-file permissions.
Changes:
- Sets restrictive state-directory permissions and
umask 077. - Records the successful apply, proofs, and teardown.
- Updates roadmap and changelog status.
| File | Description |
|---|---|
docs/runbooks/provision-lab-guests.md |
Secures and records the first apply workflow. |
docs/roadmap.md |
Marks #445 complete. |
docs/changelog.md |
Adds the 2026-10-03 completion record. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Gerrrt
enabled auto-merge (squash)
October 3, 2026 05:23
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #445.
The first apply has run, and both halves of the proof the issue asked for passed against real state on
phoenix. That was the last condition Gerrrt/HomeLab#803 left open.As run, 2026-10-03
phoenix.envlines added,Pool.Allocategranted on/pool/proof, and the passphrase escrowed (Gerrrt/HomeLab#826). Onprometheus, the hash of what the estate key decrypts equals the one taken onphoenix.tofu-proofwas cloned in full from 901 into theproofpool, with the expected shape.check-tofu-state-encryption.shpassed on the real state: it is the encrypted wrapper with no gitleaks match, and the proof guest's cloud-init password is absent. A grep for the passphrase returned 0.git addwas refused by.gitignore. With-f,check-tracked-artefacts.shnamedtofu/state/lab.tfstateand exited 1.Saruman, I confirmed there is no 998, no pool, novm-998disk, and no/pool/proofACL.Changes
provision-lab-guests.mdstep 4: the first apply wrote the state file as mode 664, because tofu creates it under the shell's umask. It was ciphertext, but ADR-0076 counts file permissions as part of the control. I fixed the permissions onphoenix, and step 4 now setsumask 077and a 700tofu/state/before any tofu command.provision-lab-guests.mdstep 6: the as-run table is filled in.docs/roadmap.md: Provision lab VMs with OpenTofu, and encrypt the state before the first apply #445 is marked done in the automation chain.docs/changelog.md: a 2026-10-03 entry.🤖 Generated with Claude Code