Repository navigation
docs: the lab domain's six guests are built and joined (#414) - #777
Merged
Merged
Conversation
architecture.md still had bahamut, leviathan, titan and ramuh as not built yet and carbuncle and siren as built, not joined. All six were read on 2026-10-01 by qm guest exec: each reports PartOfDomain for ad.matrix.elysium, with bahamut the PDC, leviathan the backup DC, titan and ramuh member servers, and the two endpoints member workstations. - architecture: the six rows drop their markers and carry the build dates. - network: rows for the four servers, and the endpoint note says joined. - changelog: what was read and how. #414 stays open for its §6, §10 and §11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The network notes still contradict the updated inventory by stating that Saruman has only three guests.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Documents the completed build and domain join status of the six Windows lab guests.
Changes:
- Updates architecture and VLAN 30 inventory.
- Records domain-role verification and build dates.
- Notes remaining work under #414.
| File | Description |
|---|---|
docs/architecture.md |
Marks all six guests built and joined. |
docs/network.md |
Adds four servers and updates endpoint status. |
docs/changelog.md |
Records verification evidence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Gerrrt
enabled auto-merge (squash)
October 1, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refs #414. It stays open for §6 (the authentication generator), §10 and §11.
docs/architecture.mdstill markedbahamut,leviathan,titanandramuhNot built yet, andcarbuncleandsirenBuilt, not joined. The domain was built by hand on 2026-09-24 and 25, and the lab Prometheus has scraped all six on:9182since 2026-09-26. Copilot's review of #774 read those rows literally as "six still planned", which is how this came up.Verified, not assumed
On 2026-10-01 I read each guest with
qm guest execfrom Saruman:PartOfDomainbahamutleviathantitanramuhcarbunclesirenAlso,
carbuncleauthenticated totitanasCARBUNCLE$over Kerberos during #437's checks.Changes
docs/architecture.md: the six rows drop their markers and say when they were built. The DCs are "promoted" and the members "joined".docs/network.md: rows for the four servers in the VLAN 30 table, and the endpoints note now says they're joined.check_docs.pyrequires these rows once a host's "not built" marker is gone.docs/changelog.md: a dated entry recording what was read and how.Checks:
check_docs.pyand markdownlint-cli2 pass.🤖 Generated with Claude Code